chore: remove dead code and add Periphery

midori-no-me · Feb 2, 2025 · b7c6c38 · b7c6c38
1 parent 2c38e56
commit b7c6c38
Show file tree

Hide file tree

Showing 41 changed files with 82 additions and 573 deletions.
diff --git a/.github/workflows/code_qualty.yaml b/.github/workflows/code_qualty.yaml
@@ -3,6 +3,27 @@ name: Code Quality
 on: pull_request
 
 jobs:
+  xcodegen:
+    name: XcodeGen
+    runs-on: macos-15
+
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+
+      - name: Install XcodeGen
+        run: brew install xcodegen
+
+      - name: Generate Xcode Configs
+        run: xcodegen generate
+
+      - name: Upload Ichime.xcodeproj Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: Ichime.xcodeproj
+          path: ./Ichime.xcodeproj/
+          retention-days: 7
+
   swift_format:
     name: swift-format
     runs-on: macos-15
@@ -38,3 +59,24 @@ jobs:
 
       - name: Check Code Formatting
         run: swiftlint --strict
+
+  periphery:
+    name: Periphery
+    runs-on: macos-15
+    needs: [xcodegen]
+
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+
+      - name: Install Periphery
+        run: brew install periphery
+
+      - name: Download Ichime.xcodeproj Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: Ichime.xcodeproj
+          path: ./Ichime.xcodeproj/
+
+      - name: Check For Unused Code
+        run: periphery scan
diff --git a/.gitignore b/.gitignore
@@ -2,6 +2,7 @@
 /.idea/
 /.vscode/
 /Ichime.xcodeproj/
+/DerivedData/
 .DS_Store
 *.app
 *.ipa

diff --git a/.periphery.yml b/.periphery.yml
@@ -0,0 +1,4 @@
+project: Ichime.xcodeproj
+retain_public: true
+schemes:
+- Ichime_tvOS
diff --git a/Ichime/AppPreferences/PlayerPreference.swift b/Ichime/AppPreferences/PlayerPreference.swift
diff --git a/Ichime/Calendar/Model/ShowFromCalendar.swift b/Ichime/Calendar/Model/ShowFromCalendar.swift
@@ -1,4 +1,3 @@
-import Anime365ApiClient
 import Foundation
 import ShikimoriApiClient
 
@@ -12,27 +11,9 @@ struct ShowFromCalendar: Hashable, Identifiable {
     let translated: TranslatedTitles
   }
 
-  enum BroadcastType {
-    case tv
-    case other
-
-    static func createFromApiType(apiType: String) -> Self {
-      switch apiType {
-      case "tv":
-        return .tv
-      default:
-        return .other
-      }
-    }
-  }
-
   let id: Int
   let title: Title
   let posterUrl: URL?
-  let score: Float?
-  let numberOfEpisodes: Int?
-  let broadcastType: BroadcastType
-  let isOngoing: Bool
   let nextEpisodeNumber: Int
   let nextEpisodeReleaseDate: Date
 
@@ -58,10 +39,6 @@ struct ShowFromCalendar: Hashable, Identifiable {
         )
       ),
       posterUrl: URL(string: shikimoriBaseUrl.absoluteString + anime.image.original),
-      score: score <= 0 ? nil : Float(anime.score),
-      numberOfEpisodes: anime.episodes <= 0 ? nil : anime.episodes,
-      broadcastType: .createFromApiType(apiType: anime.kind),
-      isOngoing: anime.status == "ongoing",
       nextEpisodeNumber: calendarEntry.next_episode,
       nextEpisodeReleaseDate: isoDateFormatter.date(from: calendarEntry.next_episode_at)!
     )

diff --git a/Ichime/ContentView/ContentView.swift b/Ichime/ContentView/ContentView.swift
@@ -1,4 +1,3 @@
-import ScraperAPI
 import SwiftUI
 
 private enum NavigationStyle: String {

diff --git a/Ichime/ContentView/ContentViewWithSideBar.swift b/Ichime/ContentView/ContentViewWithSideBar.swift
@@ -1,9 +1,7 @@
-import ScraperAPI
 import SwiftData
 import SwiftUI
 
 struct ContentViewWithSideBar: View {
-  @Environment(\.modelContext) private var modelContext
   @AppStorage("ContentViewWithTabView.selectedTab") private var selectedTab: Tabs = .home
 
   @State private var route: Route?
@@ -101,10 +99,10 @@ struct ContentViewWithSideBar: View {
       switch action {
       case URLActions.show.rawValue:
         print("its show \(id)")
-        self.route = Route(id: id, type: .show, title: nil)
+        self.route = Route(id: id, type: .show)
       case URLActions.episode.rawValue:
         print("its episode \(id)")
-        self.route = Route(id: id, type: .episode, title: episodeTitle)
+        self.route = Route(id: id, type: .episode)
       default:
         print("idk")
       }
@@ -120,5 +118,4 @@ enum URLActions: String {
 struct Route: Hashable, Identifiable {
   let id: Int
   let type: URLActions
-  let title: String?
 }
diff --git a/Ichime/ContentView/ContentViewWithTabBar.swift b/Ichime/ContentView/ContentViewWithTabBar.swift
@@ -1,9 +1,7 @@
-import ScraperAPI
 import SwiftData
 import SwiftUI
 
 struct ContentViewWithTabBar: View {
-  @Environment(\.modelContext) private var modelContext
   @AppStorage("ContentViewWithTabView.selectedTab") private var selectedTab: Tabs = .home
   @State private var route: Route?
 
@@ -103,10 +101,10 @@ struct ContentViewWithTabBar: View {
       switch action {
       case URLActions.show.rawValue:
         print("its show \(id)")
-        self.route = Route(id: id, type: .show, title: nil)
+        self.route = Route(id: id, type: .show)
       case URLActions.episode.rawValue:
         print("its episode \(id)")
-        self.route = Route(id: id, type: .episode, title: episodeTitle)
+        self.route = Route(id: id, type: .episode)
       default:
         print("idk")
       }

diff --git a/Ichime/CurrentlyWatching/Component/WatchCard.swift b/Ichime/CurrentlyWatching/Component/WatchCard.swift
@@ -1,8 +1,6 @@
 import SwiftUI
 
 struct WatchCard: View {
-  private let ROW_PADDING: CGFloat = 4
-
   let data: WatchCardModel
 
   var body: some View {
@@ -25,7 +23,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "2 серия",
           sideText: "Русские субтитры",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -35,7 +33,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "OVA 2 серия",
           sideText: "Русская озвучка",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -45,7 +43,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "Фильм",
           sideText: "RAW",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -55,7 +53,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "Фильм",
           sideText: "RAW",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -70,7 +68,7 @@ struct WatchCard: View {
           ),
           title: "Фильм",
           sideText: "RAW",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -80,7 +78,7 @@ struct WatchCard: View {
           name: .init(ru: "Братик-братик 2", romaji: "Shixiong A Shixiong 2nd Season"),
           title: "Фильм",
           sideText: "RAW",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
     }
@@ -99,7 +97,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "2 серия",
           sideText: "Вышло сегодня",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -109,7 +107,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "2 серия",
           sideText: "Вышло 18.01.24",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -119,7 +117,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "OVA 2 серия",
           sideText: "Смотрели вчера",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -129,7 +127,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "Фильм",
           sideText: "В плане с 18.01.24",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -139,7 +137,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "4000 серия",
           sideText: "В плане сегодня",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -149,7 +147,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "4000 серия",
           sideText: "Запланировали 18.01.24",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -159,7 +157,7 @@ struct WatchCard: View {
           name: .init(ru: "Взрывной храбрец Брейверн", romaji: "Yuuki Bakuhatsu Bang Bravern"),
           title: "Фильм",
           sideText: "Запланировали 18.01.24",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -174,7 +172,7 @@ struct WatchCard: View {
           ),
           title: "Фильм",
           sideText: "Запланировали 18.01.24",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
       WatchCard(
@@ -184,7 +182,7 @@ struct WatchCard: View {
           name: .init(ru: "Братик-братик 2", romaji: "Shixiong A Shixiong 2nd Season"),
           title: "Фильм",
           sideText: "Запланировали 18.01.24",
-          data: .init(episode: 1, title: "2 серия", translation: 1)
+          data: .init(episode: 1)
         )
       )
     }

diff --git a/Ichime/CurrentlyWatching/Model/WatchCardModel.swift b/Ichime/CurrentlyWatching/Model/WatchCardModel.swift
@@ -22,8 +22,6 @@ extension ScraperAPI.Types.WatchShow.UpdateType {
 struct WatchCardModel: Equatable, Identifiable, Hashable {
   struct WatchData: Hashable {
     let episode: Int
-    let title: String
-    let translation: Int?
   }
 
   let id: Int
@@ -56,7 +54,7 @@ struct WatchCardModel: Equatable, Identifiable, Hashable {
       name: show.name,
       title: show.episode.displayName,
       sideText: show.update.displayName,
-      data: .init(episode: show.episode.id, title: show.episode.displayName, translation: nil)
+      data: .init(episode: show.episode.id)
     )
   }
 
@@ -68,9 +66,7 @@ struct WatchCardModel: Equatable, Identifiable, Hashable {
       title: notification.episode.displayName,
       sideText: notification.translation.type,
       data: .init(
-        episode: notification.episode.id,
-        title: notification.episode.displayName,
-        translation: notification.translation.id
+        episode: notification.episode.id
       )
     )
   }

diff --git a/Ichime/DependencyInjection/ServiceLocator.swift b/Ichime/DependencyInjection/ServiceLocator.swift
@@ -1,6 +1,4 @@
-import Anime365ApiClient
 import Foundation
-import ScraperAPI
 
 enum ServiceLocator {
   static let appGroup = "group.dev.midorinome.ichime.group"
@@ -34,18 +32,6 @@ enum ServiceLocator {
     return appName
   }
 
-  static var permittedScheduleBGTaskName: String {
-    guard
-      let tasks = Bundle.main.object(forInfoDictionaryKey: "BGTaskSchedulerPermittedIdentifiers")
-        as? [String],
-      let task = tasks.first
-    else {
-      fatalError("Cannot get bg task name")
-    }
-
-    return task
-  }
-
   static var applicationVersion: String {
     guard
       let version = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString")