Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add envFrom to nginx-static deployment #75

Merged
merged 2 commits into from
May 13, 2024

Conversation

gerardsegarra
Copy link
Contributor

We need some secrets for one of our services that uses this. With this, we can add the envFrom config in the values file.

By default, it won't add envFrom into the manifest but when adding to the values.yaml:

envFrom:         
  - configMapRef:
      name: env-configmap
  - secretRef:
      name: env-secrets

it will add so to the manifest. Based on this.

@gerardsegarra gerardsegarra requested review from duhow and a team May 13, 2024 12:13
@gerardsegarra gerardsegarra merged commit d299427 into main May 13, 2024
2 checks passed
@gerardsegarra gerardsegarra deleted the nginx-envFrom branch May 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants