Added SQL injection test: DROP TABLE. Refs gh-127

midgardproject · Nov 14, 2011 · 6acb94e · 6acb94e
1 parent 50b4462
commit 6acb94e
Show file tree

Hide file tree

Showing 3 changed files with 73 additions and 4 deletions.
diff --git a/tests/midgard_test_database_provider.c b/tests/midgard_test_database_provider.c
@@ -471,6 +471,67 @@ _midgard_test_database_provider_complex_escape (const gchar *provider)
 	g_object_unref (config_global);
 }
 
+static void 
+_midgard_test_database_provider_sql_injection_drop_table (const gchar *provider)
+{
+	midgard_test_database_provider_connection_init (provider);
+
+	MidgardQueryStorage *storage = midgard_query_storage_new (TEST_CLASS_NAME);
+	MidgardQuerySelect *select = midgard_query_select_new (mgd_global, storage);
+
+	MidgardQueryConstraintGroup *group = midgard_query_constraint_group_new ();
+
+	MidgardQueryProperty *mqp = midgard_query_property_new ("name", NULL);
+	GValue strval = {0, };
+	g_value_init (&strval, G_TYPE_STRING);
+	g_value_set_string (&strval, "fake); DROP TABLE snippet;");
+	MidgardQueryValue *mqv = midgard_query_value_create_with_value ((const GValue*) &strval);
+	g_value_unset (&strval);
+	MidgardQueryConstraint *mqc = midgard_query_constraint_new (mqp, "=", MIDGARD_QUERY_HOLDER (mqv), NULL);
+	midgard_query_constraint_group_add_constraint (group, MIDGARD_QUERY_CONSTRAINT_SIMPLE (mqc));
+
+	g_value_init (&strval, G_TYPE_STRING);
+	g_value_set_string (&strval, "fake'); DROP TABLE snippet;");
+	MidgardQueryValue *mqvA = midgard_query_value_create_with_value ((const GValue*) &strval);
+	g_value_unset (&strval);
+	MidgardQueryConstraint *mqcA = midgard_query_constraint_new (mqp, "=", MIDGARD_QUERY_HOLDER (mqvA), NULL);
+	midgard_query_constraint_group_add_constraint (group, MIDGARD_QUERY_CONSTRAINT_SIMPLE (mqcA));
+
+	g_value_init (&strval, G_TYPE_STRING);
+	g_value_set_string (&strval, "fake'; DROP TABLE snippet;");
+	MidgardQueryValue *mqvB = midgard_query_value_create_with_value ((const GValue*) &strval);
+	g_value_unset (&strval);
+	MidgardQueryConstraint *mqcB = midgard_query_constraint_new (mqp, "=", MIDGARD_QUERY_HOLDER (mqvB), NULL);
+	midgard_query_constraint_group_add_constraint (group, MIDGARD_QUERY_CONSTRAINT_SIMPLE (mqcB));
+
+	g_value_init (&strval, G_TYPE_STRING);
+	g_value_set_string (&strval, "fake; DROP TABLE snippet;");
+	MidgardQueryValue *mqvC = midgard_query_value_create_with_value ((const GValue*) &strval);
+	g_value_unset (&strval);
+	MidgardQueryConstraint *mqcC = midgard_query_constraint_new (mqp, "=", MIDGARD_QUERY_HOLDER (mqvC), NULL);
+	midgard_query_constraint_group_add_constraint (group, MIDGARD_QUERY_CONSTRAINT_SIMPLE (mqcC));
+
+	midgard_query_executor_set_constraint (MIDGARD_QUERY_EXECUTOR (select), MIDGARD_QUERY_CONSTRAINT_SIMPLE (group));
+
+	GError *err = NULL;
+	midgard_executable_execute (MIDGARD_EXECUTABLE (select), &err);
+
+	g_object_unref (storage);
+	g_object_unref (select);
+	g_object_unref (mqp);
+	g_object_unref (mqv);
+	g_object_unref (mqc);
+	g_object_unref (mqvA);
+	g_object_unref (mqcA);
+	g_object_unref (mqvB);
+	g_object_unref (mqcB);
+	g_object_unref (mqvC);
+	g_object_unref (mqcC);
+	g_object_unref (group);
+
+	g_assert (err == NULL);
+}
+
 void	
 midgard_test_database_provider_mysql_escape (void)
 {
@@ -508,10 +569,15 @@ midgard_test_database_provider_sqlite_complex_escape (void)
 }
 
 void	
-midgard_test_database_provider_sql_injection (void)
+midgard_test_database_provider_sqlite_sql_injection_drop_table (void)
+{
+	_midgard_test_database_provider_sql_injection_drop_table ("SQLite");
+}
+
+void	
+midgard_test_database_provider_mysql_sql_injection_drop_table (void)
 {
-	/* TODO */
-	return;
+	_midgard_test_database_provider_sql_injection_drop_table ("MySQL");
 }
 
 static void 

diff --git a/tests/midgard_test_database_provider.h b/tests/midgard_test_database_provider.h
@@ -11,7 +11,8 @@ void	midgard_test_database_provider_sqlite_double_escape	(void);
 void	midgard_test_database_provider_mysql_complex_escape	(void);
 void	midgard_test_database_provider_sqlite_complex_escape	(void);
 
-void	midgard_test_database_sql_injection 			(void);
+void 	midgard_test_database_provider_mysql_sql_injection_drop_table	(void);
+void 	midgard_test_database_provider_sqlite_sql_injection_drop_table	(void);
 
 void	midgard_test_database_provider_sqlite_utf8_chars 	(void);
 void	midgard_test_database_provider_mysql_utf8_chars 	(void);

diff --git a/tests/run-midgard-test-database-provider.c b/tests/run-midgard-test-database-provider.c
@@ -32,13 +32,15 @@ int main (int argc, char *argv[])
 	g_test_add_func("/midgard_database_provider/mysql_double_escape", midgard_test_database_provider_mysql_double_escape);
 	g_test_add_func("/midgard_database_provider/mysql_complex_escape", midgard_test_database_provider_mysql_complex_escape);
 	g_test_add_func("/midgard_database_provider/mysql_utf8_chars", midgard_test_database_provider_mysql_utf8_chars); 
+	g_test_add_func("/midgard_database_provider/mysql_injection_drop_table", midgard_test_database_provider_mysql_sql_injection_drop_table);
 
 	/* SQLite */
 
 	g_test_add_func("/midgard_database_provider/sqlite_escape", midgard_test_database_provider_sqlite_escape);
 	g_test_add_func("/midgard_database_provider/sqlite_double_escape", midgard_test_database_provider_sqlite_double_escape);
 	g_test_add_func("/midgard_database_provider/sqlite_complex_escape", midgard_test_database_provider_sqlite_complex_escape);
 	g_test_add_func("/midgard_database_provider/sqlite_utf8_chars", midgard_test_database_provider_sqlite_utf8_chars);
+	g_test_add_func("/midgard_database_provider/sqlite_injection_drop_table", midgard_test_database_provider_sqlite_sql_injection_drop_table);
 
 	return g_test_run();
 }