Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove svgz from default file types #239180

Merged
merged 2 commits into from
Jan 31, 2025
Merged

remove svgz from default file types #239180

merged 2 commits into from
Jan 31, 2025

Conversation

joaomoreno
Copy link
Member

fixes #231021

@joaomoreno joaomoreno self-assigned this Jan 30, 2025
@joaomoreno joaomoreno enabled auto-merge (squash) January 30, 2025 09:06
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 30, 2025
alexr00
alexr00 previously approved these changes Jan 30, 2025
View reviewed changes
@bpasero
Copy link
Member

bpasero commented Jan 30, 2025

@joaomoreno

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?
 M build/lib/electron.js

@joaomoreno joaomoreno merged commit 9d43b07 into main Jan 31, 2025
8 checks passed
@joaomoreno joaomoreno deleted the joao/copper-ape branch January 31, 2025 09:49
@skycommand
Copy link

You fixed it! 🎉

This is the first time one of the VSCode issues I reported gets fixed. So you guys do fix bugs after all. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

@alexr00 alexr00 alexr00 left review comments

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.

VS Code erroneously registers itself with as a .SVGZ handler
4 participants
@joaomoreno @bpasero @skycommand @alexr00