-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the settings for the lightbulb code action menu #199786
Conversation
Following the review discussion, the code inside of
Additionally the following listener is added in order to trigger an update of the UI when the configuration changes for the lightbulb setting
|
ll looks good to me. We can merge the PR if @alexdima and @justschen like the direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two small comments.
Added the review changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @justschen Please also take a look. The thinking behind these changes is captured at #200538
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! the migration and everything looks good :D
…ettingsForTheLightbulb Changing the settings for the lightbulb code action menu
In relation to slack conversation
fixes #200538