Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch VB language to different fork #147690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kant2002
Copy link

The original project is not maintained anymore so I decide to take maintenance.
Not sure if this is proper place to change, but if yes, then I hope during next sync commit kant2002/asp.vb.net.tmbundle@5164486 will land in this repo.

The original project is not maintained [anymore](textmate/asp.vb.net.tmbundle#11) so I decide to take maintainance.
Not sure if this is proper place, but if yes, then I hope during next sync commit kant2002/asp.vb.net.tmbundle@5164486 will land in this repo.
@Tyriar Tyriar assigned aeschli and unassigned Tyriar Jul 5, 2022
@aeschli aeschli assigned alexr00 and unassigned aeschli Jul 5, 2022
@alexr00
Copy link
Member

alexr00 commented Jul 5, 2022

@kant2002 thanks for your interest in improving the VB syntax highlighting support! We have a number of grammars that have been abandoned like this, so it's always great when someone offers a better maintained one. I usually prefer to see some longer running support and use before switching to a new repo for a grammar. Would you be amenable to creating a VS Code extension with your grammar? You would be able to copy a lot of the built-in VB extension's package.json. Then, after it's been in the wild for a month or two we can revisit this switch.

@alexr00 alexr00 added this to the On Deck milestone Jul 5, 2022
@kant2002
Copy link
Author

kant2002 commented Jul 5, 2022

@alexr00 that totally make sense. Can you point me of similar single purpose extension? Or should I just follow tutorial for new language extension and that's all what I need?

@kant2002
Copy link
Author

kant2002 commented Jul 5, 2022

Other problem which I do not know how to solve is marketing. I do not have clout in VB community, and made fix because it affects me. and because VB syntax works mostly out of the box, people would not even look for other alternatives. So I do not expect that my small change would be hugely important. Also consider that people who work with VS Code tolerate these small errors much better then IDE users because they have lower expectations to VS code.

@alexr00
Copy link
Member

alexr00 commented Jul 6, 2022

Can you point me of similar single purpose extension? Or should I just follow tutorial for new language extension and that's all what I need?

The tutorial for a new language extension should get you started well.

So I do not expect that my small change would be hugely important.

@kant2002 do you plan to make additional improvements to the grammar?

@kant2002
Copy link
Author

kant2002 commented Jul 7, 2022

The tutorial for a new language extension should get you started well.

Thanks, thats fine. Now I understand what you are proposing.

do you plan to make additional improvements to the grammar?

I do have to find additional issues with it,. I definitely want to make things working for VB, but I cannot predict what currently is broken (hopefully not much)

@alexr00
Copy link
Member

alexr00 commented Dec 10, 2024

@kant2002, I'm going to close this as part of our housekeeping since there hasn't been any activity in a while, but if this is still something you want to work on let me know!

@alexr00 alexr00 closed this Dec 10, 2024
@kant2002
Copy link
Author

@alexr00 I definitely want to have VB grammar to be fixed. So if you can, please reopen

@alexr00 alexr00 reopened this Dec 10, 2024
@alexr00 alexr00 added help wanted Issues identified as good community contribution opportunities and removed help wanted Issues identified as good community contribution opportunities labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants