Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collapsing/expanding notebook cell comments #236600

Open
rehmsen opened this issue Dec 19, 2024 · 1 comment
Open

Support collapsing/expanding notebook cell comments #236600

rehmsen opened this issue Dec 19, 2024 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality notebook
Milestone

Comments

@rehmsen
Copy link
Contributor

rehmsen commented Dec 19, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: macOS 15.1.1 (24B91)
  • OS Version: 1.96.1

Steps to Reproduce:

  1. Create a review comment on a notebook cell.
  2. Press the collapse button.

Expected:
Collapses the comment somehow.

Actual:
Nothing happens.


Looks like this was never implemented for notebooks:

I guess one challenge in implementing is coming up with a UX for collapsed comments and how to uncollapse them, given there is no line gutter icon which is used on text files for that. Maybe we could have a similar red icon in the bottom margin that also has the language picker on the far right. There is some space there, and it is relatively close to where the comments would be...

What do you think, @rebornix?

Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.96.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@rebornix rebornix added feature-request Request for new features or functionality notebook labels Dec 19, 2024
@rebornix rebornix added this to the Backlog milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality notebook
Projects
None yet
Development

No branches or pull requests

2 participants