chat.action.* commands are inconsistent with workbench.action.chat.*

[Tyriar]

They're new so we should be consistent.

vscode/src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

Lines 80 to 102 in b2a4823

	registerAction2(class FocusChatAction extends EditorAction2 {
	constructor() {
	super({
	id: 'chat.action.focus',
	title: { value: localize('actions.interactiveSession.focus', "Focus Chat List"), original: 'Focus Chat List' },
	precondition: CONTEXT_IN_CHAT_INPUT,
	category: CHAT_CATEGORY,
	keybinding: {
	when: EditorContextKeys.textInputFocus,
	primary: KeyMod.CtrlCmd | KeyCode.UpArrow,
	weight: KeybindingWeight.EditorContrib
	}
	});
	}
	runEditorCommand(accessor: ServicesAccessor, editor: ICodeEditor): void | Promise<void> {
	const editorUri = editor.getModel()?.uri;
	if (editorUri) {
	const widgetService = accessor.get(IChatWidgetService);
	widgetService.getWidgetByInputUri(editorUri)?.focusLastMessage();
	}
	}
	});

vscode/src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

Lines 37 to 59 in b2a4823

	registerEditorAction(class ChatAcceptInput extends EditorAction {
	constructor() {
	super({
	id: 'chat.action.acceptInput',
	label: localize({ key: 'actions.chat.acceptInput', comment: ['Apply input from the chat input box'] }, "Accept Chat Input"),
	alias: 'Accept Chat Input',
	precondition: CONTEXT_IN_CHAT_INPUT,
	kbOpts: {
	kbExpr: EditorContextKeys.textInputFocus,
	primary: KeyCode.Enter,
	weight: KeybindingWeight.EditorContrib
	}
	});
	}
	run(accessor: ServicesAccessor, editor: ICodeEditor): void | Promise<void> {
	const editorUri = editor.getModel()?.uri;
	if (editorUri) {
	const widgetService = accessor.get(IChatWidgetService);
	widgetService.getWidgetByInputUri(editorUri)?.acceptInput();
	}
	}
	});

[roblourens]

Which one do you like better?

[roblourens]

I guess I'll go with whatever is least likely to break keybindings or other usages

[Tyriar]

Our naming of commands is a bit all over the place, hard to say which is better since we didn't strictly stick to the workbench. naming scheme

[roblourens]

I think they are all consistent except for chat.action.focus. And unfortunately I think I should have moved quicker on that but it's one that is likely to have customized keybindings, and I don't really want to touch the ID now.