Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fonts that print underscore beyond a cell's height don't render anything in the DOM renderer #159110

Open
Tyriar opened this issue Aug 24, 2022 · 1 comment
Open

Fonts that print underscore beyond a cell's height don't render anything in the DOM renderer #159110

Tyriar opened this issue Aug 24, 2022 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2022

Not a regression, just noticed while investigating #158497

It should be this_that:

image

The font in question Droid Sans Mono, probably DejaVu Sans Mono too which default on a lot of Linux distros write the underscore below the natural height of the char.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-rendering labels Aug 24, 2022
@Tyriar Tyriar added this to the Backlog milestone Aug 24, 2022
This was referenced Aug 24, 2022
Open
Closed
@meganrogge meganrogge removed their assignment Dec 5, 2022
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Dec 13, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Dec 10, 2024

Upstream: xtermjs/xterm.js#4067

@Tyriar Tyriar mentioned this issue Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge