Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Python3.13 CI tests issues for REPL #24773

Closed
anthonykim1 opened this issue Feb 3, 2025 · 1 comment · Fixed by #24775
Closed

Resolve Python3.13 CI tests issues for REPL #24773

anthonykim1 opened this issue Feb 3, 2025 · 1 comment · Fixed by #24775
Assignees
@anthonykim1
Labels
area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team

Comments

@anthonykim1
Copy link

Although we tested for cases for Python bracketed paste mode for both below, above version 3.13 starting at: https://github.com/anthonykim1/vscode-python/blob/2cc70079dc7206e98fedbd1a790a702d0f863703/src/test/terminals/codeExecution/helper.test.ts#L139

CI tests started failing when the env in the CI started using 3.13 for some reason for normalization code.
There is no bug, it is just that legacy test was not properly protected against bracketed paste mode.
@anthonykim1 anthonykim1 added area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 3, 2025
@anthonykim1 anthonykim1 self-assigned this Feb 3, 2025
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 3, 2025
@anthonykim1 anthonykim1 mentioned this issue Feb 3, 2025
Open
@anthonykim1
Copy link
Author

anthonykim1 commented Feb 3, 2025 •
edited
Loading

TODO: #24774 for adding tests for bracketed paste mode normalized code for Python >= 3.13

@anthonykim1 anthonykim1 mentioned this issue Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-repl debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve >= 3.13 failing REPL CI tests anthonykim1/vscode-python
1 participant
@anthonykim1