Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test discovery cancellable #24602

Closed
karthiknadig opened this issue Dec 13, 2024 · 3 comments · Fixed by #24713
Closed

Make test discovery cancellable #24602

karthiknadig opened this issue Dec 13, 2024 · 3 comments · Fixed by #24713
Assignees
Labels
area-testing feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

Currently, the auto-discovery run is not cancellable. This can some times get in the way when say pytest is not installed , and you install pytest it can prevent from running immediately. May be, we can check if pytest exists or if path is provided, if eithe is true then run discovery using withProgress API so even the auto discover can be cancelled.

@karthiknadig karthiknadig added area-testing feature-request Request for new features or functionality labels Dec 13, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 13, 2024
@eleanorjboyd eleanorjboyd added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Dec 16, 2024
eleanorjboyd added a commit that referenced this issue Jan 14, 2025
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this issue Jan 17, 2025
@karthiknadig karthiknadig added this to the January 2025 milestone Jan 27, 2025
@karthiknadig karthiknadig added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Jan 27, 2025
@roblourens roblourens added the verification-steps-needed Steps to verify are needed for verification label Jan 28, 2025
@roblourens
Copy link
Member

I see progress on the view, but nothing that I can use to cancel discovery? Maybe it's too fast? What should I see?

@eleanorjboyd
Copy link
Member

it should work with very repos that have a very large number of tests - I know https://github.com/pypa/packaging has a lot. Maybe someone from the python team with a large repo could test? @karthiknadig @anthonykim1 @luabud @cwebster-99

@eleanorjboyd eleanorjboyd removed the verification-steps-needed Steps to verify are needed for verification label Jan 30, 2025
@karthiknadig
Copy link
Member Author

The repro is enable autosave with short time duration between saves or trigger a lot of saves while making changes. Then make random edits to the files. For a repo like packaging, it should take a few seconds to finish discovery. So, with these changes, you may see it hang.

@connor4312 connor4312 added the verified Verification succeeded label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants