Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart send needs some UI affordance to notify the user what code was actually sent #22543

Closed
isidorn opened this issue Nov 28, 2023 · 4 comments
Assignees
Labels
area-repl needs community feedback Awaiting community feedback needs proposal Need to make some design decisions

Comments

@isidorn
Copy link

isidorn commented Nov 28, 2023

Testing #22536

Right now it is hard to figure out what code actually gets sent as part of "Smart Send".
We need some UI affordance to decorate code that was actually sent. So we give more transparency to the user what is going on.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 28, 2023
@anthonykim1
Copy link

Thanks for the feedback! Do you mean something like notification at the bottom that shows code block that was just ran by smart send with shift+enter?

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Dec 8, 2023
@isidorn
Copy link
Author

isidorn commented Dec 11, 2023

No. I would not like a notification.
There are decoration that you could potentially use https://code.visualstudio.com/api/references/vscode-api#DecorationRangeBehavior

So imagine them as additional UI inside the editor. For example, errors squiggly underlines are decorations. You could have some background decorations or something to show what code was executed as part of smart send.

@github-actions github-actions bot removed the info-needed Issue requires more information from poster label Dec 11, 2023
@anthonykim1 anthonykim1 added needs proposal Need to make some design decisions needs community feedback Awaiting community feedback area-repl and removed triage-needed Needs assignment to the proper sub-team labels Nov 21, 2024
Copy link

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@anthonykim1
Copy link

I want to merge this with: #22558

@anthonykim1 anthonykim1 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl needs community feedback Awaiting community feedback needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

2 participants