Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for parameterized tests with renamed IDs #21367

Closed
eleanorjboyd opened this issue Jun 5, 2023 · 1 comment
Closed

Add test for parameterized tests with renamed IDs #21367

eleanorjboyd opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@eleanorjboyd
Copy link
Member

add a test to confirm this scenario is correct. The IDs displayed for the given tests should be test_adding[test_adding], test_adding[2+V], and test_adding[6s+9]

@pytest.mark.parametrize(
    "actual, expected",
    [("3+2", 5), ("2+4", 6), ("6+9", 16)],
    ids=["test_adding", "2+V", "6s+9"],
)
def test_adding(actual, expected):
    assert eval(actual) == expected
@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Jun 5, 2023
@eleanorjboyd eleanorjboyd self-assigned this Jun 5, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 5, 2023
@eleanorjboyd
Copy link
Member Author

also make sure this captures edge cases such as /n and and [enter]. (Need to check if they are acceptable in pytest first then have the behavior replicated in the test explorer

@luabud luabud added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Dec 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants