auth: Fixes "Cannot read properties of undefined 'tenantId' error #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the problem was because we weren't passing 
I added the account property to our tenant interface recently #1849 |
Yes lol for some reason it wasn't showing up when I first implemented it 😅 |
alexweininger
previously approved these changes
Dec 13, 2024
| @@ -13,9 +13,12 @@ export async function getUnauthenticatedTenants(subscriptionProvider: AzureSubsc | |||
| const tenants = await subscriptionProvider.getTenants(); | |||
| const unauthenticatedTenants: TenantIdDescription[] = []; | |||
| for await (const tenant of tenants) { | |||
| if (!await subscriptionProvider.isSignedIn(tenant.tenantId)) { | |||
| unauthenticatedTenants.push(tenant); | |||
| if (tenant) { | |||
There was a problem hiding this comment.
This if statement is weird to me but I understand why you included it. Maybe add a comment for future us so we're not confused about why it's there and accidentally remove it.
nturinski
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to this rg issue for the error.
Also added the account property to isSignedIn() because for some reason I kept getting all of my tenants showing up in the list when I should only be getting unauthenticated tenants.