auth: Use setting names defined in VSCode builtin extension #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweininger
previously approved these changes
Jun 9, 2023
bwateratmsft
commented
Jun 9, 2023
| @@ -63,22 +56,27 @@ export function getConfiguredAzureEnv(): azureEnv.Environment & { isCustomCloud: | |||
| /** | |||
| * Sets the configured Azure cloud. | |||
| * | |||
| * @param cloud Use `'AzureCloud'` for public Azure cloud, `'AzureChinaCloud'` for Azure China, or `'AzureUSGovernment'` for Azure US Government. | |||
| * @param cloud Use `'AzureCloud'` or `undefined` for public Azure cloud, `'ChinaCloud'` for Azure China, or `'USGovernment'` for Azure US Government. | |||
There was a problem hiding this comment.
This is technically a breaking change but I'm not going to rev the major version for it at this point.
nturinski
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding to microsoft/vscode#184634
Fixes #1490
/cc @TylerLeonhardt, @alexweininger