all: Switch to l10n API
#1399
Merged
all: Switch to l10n API
#1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
changed the title
l10n APIl10n API
nturinski
approved these changes
Apr 19, 2023
| @@ -31,12 +30,13 @@ export async function swapSlot(context: IActionContext, sourceSlot: ParsedSite, | |||
| } | |||
| } | |||
|
|
|||
| const placeHolder: string = localize('selectSlotToSwap', 'Select which slot to swap with "{0}".', sourceSlot.slotName); | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| const placeHolder: string = l10n.t('Select which slot to swap with "{0}".', sourceSlot.slotName!); | |||
There was a problem hiding this comment.
Normally I'd say we should probably use nonNullValue(), but throwing an error because of a string error seems excessive.
There was a problem hiding this comment.
I think it's also partly because the Swagger definitions for these APIs suggest that some things can be optional, that never actually can be optional. The ! "operator" seems fitting in that scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1359.
We'll also need to cascade up the
utilsandazurepackages to fully get rid ofvscode-nls.