Add a conditional setLocation in ResourceGroupListStep
#1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
force-pushed
the
mwf/rg-set-location
branch
from
2a11c88 to
e4216ae
Compare
MicroFish91
commented
Dec 19, 2022
| @@ -46,6 +45,9 @@ export class ResourceGroupListStep<T extends types.IResourceGroupWizardContext> | |||
| // Cache resource group separately per subscription | |||
| const options: IAzureQuickPickOptions = { placeHolder: 'Select a resource group for new resources.', id: `ResourceGroupListStep/${wizardContext.subscriptionId}` }; | |||
| wizardContext.resourceGroup = (await wizardContext.ui.showQuickPick(this.getQuickPicks(wizardContext), options)).data; | |||
| if (wizardContext.resourceGroup) { | |||
| await LocationListStep.setLocation(wizardContext, nonNullProp(wizardContext.resourceGroup, 'location')); | |||
There was a problem hiding this comment.
Discussion question...
Should we always set location whenever we pick a resource group, or should it only be set if _location is undefined? Whenever we go through the flow to create a resource group, we automatically select and set the location, so I'm kind of leaning towards option A but could see both ways being feasible but having different side effects.
A)
if (wizardContext.resourceGroup) {
...
}OR
B)
if (wizardContext.resourceGroup && !LocationListStep.hasLocation(wizardContext)) {
...
}
There was a problem hiding this comment.
I think I prefer option B a little bit better. If we set the location ahead of time for whatever reason, I'd prefer to respect those settings.
nturinski
approved these changes
Dec 21, 2022
…into mwf/rg-set-location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1290
Similar to how it's done in
StorageAccountListStep.