Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@microsoft/vscode-azureresources-api, @microsoft/vscode-azext-utils, @microsoft/vscode-azext-azureutils, @microsoft/vscode-azext-azureappservice fail TypeScript lib check #1468

Closed
6 tasks done
bwateratmsft opened this issue Apr 20, 2023 · 0 comments
Closed
6 tasks done

@microsoft/vscode-azureresources-api, @microsoft/vscode-azext-utils, @microsoft/vscode-azext-azureutils, @microsoft/vscode-azext-azureappservice fail TypeScript lib check #1468

bwateratmsft opened this issue Apr 20, 2023 · 0 comments

Comments

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Apr 20, 2023 •
edited
Loading

It doesn't prevent compiling, but these packages fail the TypeScript library check, requiring consumers to either do "skipLibCheck": true in the TSConfig, or adding @azure/ms-rest-azure-env as a dev dependency. This can be fixed by making @azure/ms-rest-azure-env a peer dependency of the following packages:

@microsoft/vscode-azext-azureappservice also fails due to the KuduModels being imported from the old vscode-azurekudu package. These models should just be moved up into @microsoft/vscode-azext-azureappservice.

Lastly, @microsoft/vscode-azext-azureappservice fails due to an import instead of import type on @microsoft/vscode-azext-azureappsettings in SiteClient.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwateratmsft