Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceGroupListStep should call LocationListStep.setLocation() after a resource group is selected #1290

Closed
MicroFish91 opened this issue Dec 6, 2022 · 0 comments · Fixed by #1313
Closed

ResourceGroupListStep should call LocationListStep.setLocation() after a resource group is selected #1290

MicroFish91 opened this issue Dec 6, 2022 · 0 comments · Fixed by #1313
Labels
enhancement

Comments

@MicroFish91
Copy link
Contributor

MicroFish91 commented Dec 6, 2022 •
edited
Loading

In ResourceGroupListStep....

A location is set whenever a new resource group is created:

image

but not when it is selected from an existing list:

image

I'm thinking we should probably be consistent and call setLocation after the user has made a choice, in a similar way to how it's done in StorageAccountListStep.

Let me know if anyone can think of a reason that we shouldn't do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a conditional setLocation in ResourceGroupListStep microsoft/vscode-azuretools
1 participant
@MicroFish91