Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl3-ttf] new port #43874

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

rremilian
Copy link
Contributor

Fixes #43848
Fixes #43738

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 17, 2025
@LilyWangLL
Copy link
Contributor

Usage test failed with the following error:

1> [CMake] CMake Error at F:/PRreview/vcpkg/installed/x64-windows/share/SDL3_ttf/SDL3_ttf-shared-targets.cmake:60 (set_target_properties):
1> [CMake]   The link interface of target "SDL3_ttf::SDL3_ttf-shared" contains:
1> [CMake] 
1> [CMake]     SDL3::Headers
1> [CMake] 
1> [CMake]   but the target was not found.

@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@LilyWangLL LilyWangLL marked this pull request as draft February 18, 2025 09:37
rremilian and others added 2 commits February 20, 2025 19:17
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@rremilian
Copy link
Contributor Author

Usage test failed with the following error:

1> [CMake] CMake Error at F:/PRreview/vcpkg/installed/x64-windows/share/SDL3_ttf/SDL3_ttf-shared-targets.cmake:60 (set_target_properties):
1> [CMake]   The link interface of target "SDL3_ttf::SDL3_ttf-shared" contains:
1> [CMake] 
1> [CMake]     SDL3::Headers
1> [CMake] 
1> [CMake]   but the target was not found.

@LilyWangLL could you please tell me how to reproduce this ? I tried to reproduce it locally, but I don't get this error even when I'm linking against SDL3_ttf::SDL3_ttf-shared or SDL3::Headers. Thanks in advance.

Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@rremilian rremilian marked this pull request as ready for review February 21, 2025 15:53
@rremilian rremilian requested a review from LilyWangLL February 21, 2025 15:53
Comment on lines 11 to 12
harfbuzz SDLTTF_HARFBUZZ
svg SDLTTF_PLUTOSVG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again:

Suggested change
harfbuzz SDLTTF_HARFBUZZ
svg SDLTTF_PLUTOSVG
harfbuzz SDLTTF_HARFBUZZ
svg SDLTTF_PLUTOSVG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] SDL3 ttf [New Port Request] sdl3-ttf
3 participants