Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use authorization token from token_refresh_command during replay #932

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Use authorization token from token_refresh_command during replay #932

merged 1 commit into from
Jan 22, 2025

Conversation

vai-alkos
Copy link
Contributor

Fixes #848.

Previously used execute_token_refresh_cmd refreshes token value but does not set latest_token_value which is used later. The solution is to replace it with execute_token_refresh which will do both.

@vai-alkos
Fix microsoft#848: Use auth token from token_refresh_command during r…
f995e93 
…eplay

Replace execute_token_refresh_cmd with execute_token_refresh
to ensure the token is refreshed and set as latest_token_value.
@marina-p
Copy link
Contributor

Thank you for the fix!

marina-p
marina-p approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@marina-p marina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marina-p marina-p merged commit d6f932a into microsoft:main Jan 22, 2025
9 checks passed
@vai-alkos vai-alkos deleted the fix-issue-848 branch January 23, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marina-p marina-p marina-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replay not using AUTHORIZATION TOKEN from token_refresh_command
2 participants
@vai-alkos @marina-p