Add validation to engine dictionary #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I couldn't run the unit tests due to the following error, but I tested it separately.
I have installed the packages from requirements.txt #Resolved |
|
Hi, thank you for adding this validation. The PR and test looks good. We've had CI checks broken for a few weeks, I just re-enabled them and everything including the new test is passing, so I'll go ahead and merge this: https://github.com/microsoft/restler-fuzzer/actions/runs/12292021287. For troubleshooting running tests locally, what was the exact command/directory/environment? In reply to: 2473982009 |
marina-p
force-pushed
the
validate-dictionary
branch
from
dc85c39 to
e18d2b2
Compare
marina-p
reviewed
Jan 23, 2025
marina-p
force-pushed
the
validate-dictionary
branch
from
2384b69 to
306b9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #773
This adds a local function to see if
custom_valuesdictionary only contains strings. It will throw an error if the dictionary is not valid.I have also added a test case for testing the code change.
Please let me know if there are any changes to be made, as it is my first time contributing to this codebase.