Implementing overflow prop in View component #14527
Conversation
| ); | ||
|
|
||
| // Apply the clipping path to the visual | ||
| Visual().as<::Microsoft::ReactNative::Composition::Experimental::IVisualInterop>()->SetClippingPath( |
There was a problem hiding this comment.
We already setting the clipping path when we have borderRadii, in ComponentView::updateClippingPath. -- I think that is done today to ensure that the background has a rounded corner too.
So I think the fix here will be more complex than this.
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- change/react-native-windows-4a6abd7a-5513-40a7-bc6d-a7527518ba51.json: Language not supported
Comments suppressed due to low confidence (2)
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.h:231
- [nitpick] Consider adding an inline comment to explain the purpose of m_shouldClipChildren for future maintainability.
bool m_shouldClipChildren{false};
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.cpp:1092
- Ensure that the overflow property exclusively covers valid states (e.g., 'Hidden' and 'Scroll') when clipping children, and verify that this behavior is consistent with usage elsewhere in the codebase.
m_shouldClipChildren = (newViewProps.yogaStyle.overflow() != facebook::yoga::Overflow::Visible);
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Description
Type of Change
Why
Implement the overflow property for the fabric implementation of View.
This property was available in RNW Paper via ViewViewManager,NativeUIManager.
See https://reactnative.dev/docs/layout-props#overflow for details.
Resolves #13103
What
Implemented the overflow property for the fabric implementation of View.
Screenshots
Recording.2025-04-14.163816.mp4
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Changelog
Yes
Added a brief summary of overflow to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow