Replies: 1 comment
-
These improvements sound fantastic! We would love for you contribute any/all of them that you feel comfortable sharing. I think it would make the most sense to split this into at least a few separate PRs that we can code review and provide feedback on. For example, it would be good to separate all the AzureKinect changes into their own PR. I'll let you split the rest of them up in whatever way you prefer and is easiest for you. A few quick questions/comments based on the improvements you've listed: Thanks, and excited to see these updates! |
Beta Was this translation helpful? Give feedback.
-
Now that I'm nearly done with my degree :P, I got some free time to push back some changes and fixes I found along the way. These are changes related to Psi's core components. Please let me know if these changes are appropriate. I'm not sure if it's preferable to (1) have them as one big pull request or (2) each item as its own pull request, or (3) combinations of them.
Bug Fixes
Exporter.cs
discussed in PsiStore operations on very big stores leads to running out of memory. #207 andCropInPlace
function inPsiStore.cs
. The fix only involve passing thedeliveryPolicy
toPipeTo
which should not effect any existing code.Improvements:
Sources/Filters/Microsoft.Psi.Filters/FilterExtensions.cs
which wrapped the component as a function:IProducer<double> OneEuroFilter(this IProducer<double> input, double cutoffSlope = 0, double minCutoffFrequency = 1.0, double derivateCutoffFrequency = 1.0)
Flip
operator inSources/Imaging/Microsoft.Psi.Imaging/ImageExtensions.cs
for Depth Images and also its associated function.ReplayDescriptor(DateTime start, TimeSpan duration, bool enforceReplayClock = true)
IsolateStream
function inSources/Tools/PsiStoreTool/Utility.cs
that creates a new store with one single stream.I'm curious what y'all think about the change. I'm not sure if (2) is a good idea, it could be something people change themselves if they wanted to. The improvement (1) and (6) probably need a more fine comb code review. Please let me know if any of the items aren't clear and I'm happy to go into more details about it :)
Beta Was this translation helpful? Give feedback.
All reactions