-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NPKIT] Adding the NPKIT support for kernel allreduce7 in mscclpp #399
base: main
Are you sure you want to change the base?
[NPKIT] Adding the NPKIT support for kernel allreduce7 in mscclpp #399
Conversation
@PedramAlizadeh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. We need add test for this change in the future.
@@ -19,7 +19,9 @@ if(USE_CUDA) | |||
elseif(USE_ROCM) | |||
target_compile_definitions(mscclpp_nccl_obj PRIVATE USE_ROCM) | |||
endif() | |||
|
|||
if(NPKIT_FLAGS) | |||
target_compile_definitions(mscclpp_nccl_obj PRIVATE NPKIT_FLAGS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this flag used?
No description provided.