Support Simple protocol plans using scratch buffer #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yzygitzh
commented
Oct 22, 2024
•
yzygitzh
commented
- Separate the options whether to use packet and whether to use double buffer.
- Reduce primitive implementation fixes in executor.
- Add validation for number of operations, channels and channels per operation.
yzygitzh
changed the title
chhwang
approved these changes
Oct 24, 2024
Binyang2014
reviewed
Oct 24, 2024
src/executor/executor.cc
Outdated
Comment on lines
90
to
94
| plan.impl_->lightLoadExecutionPlan(inputMessageSize, outputMessageSize, contsSrcOffset, constDstOffset, rank, | ||
| sendBufferSize, recvBufferSize, flag); | ||
| this->setupDeviceExecutionPlan(this->contexts[key], rank, plan); | ||
| this->contexts[key].deviceExecutionPlansBuffer = | ||
| allocExtSharedCuda<char>(this->contexts[key].deviceExecutionPlans.size() * sizeof(DeviceExecutionPlan)); |
There was a problem hiding this comment.
If find the key, seems it will overwrite the previous plan. It may cause problem when using cuda graph. Only last plan will be copied to GPU memory. Maybe we need to distinguish the plan with inputMessageSize, outputMessageSize, flag. And let kernel load the plan with correct device_ptr.
|
@Binyang2014 Any updates in this PR? |
I think there not blocker for this PR. Just need to resolve the conflict. Let me check with Ziyue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.