[dev-v5] Add FluentDivider component #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed trailing comma in ButtonAppearance enum in ButtonAppearance.cs - Added HTML files as None items in Components.Tests.csproj for FluentDividerTests - Added FluentDivider.md with metadata, examples, and API reference - Added FluentDivider.razor defining the structure and attributes of the FluentDivider component - Added FluentDivider.razor.cs partial class with properties and logic for FluentDivider - Added DividerAlignContent enum in DividerAlignContent.cs for content alignment - Added DividerAppearance enum in DividerAppearance.cs for appearance styles - Added FluentDividerTests.FluentDivider_Default.verified.razor.html with a simple fluent-divider element - Added FluentDividerTests.razor with Xunit test cases for FluentDivider component
Updated FluentDividerExamples.razor to include a new FluentStack component with child components for setting FluentDivider properties interactively. Corrected attribute name in FluentDivider.razor to align-content. Added [Parameter] attributes in FluentDivider.razor.cs for bindable properties. Updated FluentDivider.md with usage details. Added new unit tests in FluentDividerTests.razor for various attributes.
Revised FluentStack orientation to horizontal with margin-bottom. Reordered FluentTextInput, FluentSelect, and FluentCheckbox components within the stack for better structure. Moved FluentDivider outside of FluentStack to the end for improved visual layout.
dvoituron
requested changes
Feb 14, 2025
Updated the `DividerAppearance` enum description for `Default` value in `DividerAppearance.cs`. Modified `FluentDivider_AlignContent` and `FluentDivider_DividerAppearance` test methods in `FluentDividerTests.razor` to accept nullable values. Added test cases for `null` and invalid enum values (`999`), expecting an empty string as the result.
dvoituron
approved these changes
Feb 15, 2025
vnbaaij
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FluentDivider component
The FluentDivider component is used to separate content within a container.
Horizontally
Vertically
Documentation
Unit Tests