Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foundation] semantic meaning for 'control' referenced elements in templates #5757

Closed
yinonov opened this issue Mar 17, 2022 · 4 comments
Closed
Labels
closed:obsolete No longer valid

Comments

@yinonov
Copy link
Contributor

yinonov commented Mar 17, 2022

looking up the repo for all control members and their paired refs in templates shows incoherent pattern.

where in most cases control refs are "A reference to the internal input element", in one case (anchor) it "References the root element".

is there a convention to setting an element as control?

if it generally follows that pattern when a native form control is used, perhaps it is an anomaly in anchor? anti-pattern?

@yinonov yinonov changed the title [foundation] semantic meaning for referenced elements in templates [foundation] semantic meaning for 'control' referenced elements in templates Mar 20, 2022
@yinonov
Copy link
Contributor Author

yinonov commented Mar 20, 2022

I believe openui/open-ui#81 addresses this issue exactly

@chrisdholt
Copy link
Member

I believe openui/open-ui#81 addresses this issue exactly

I think the intent here is slightly different, so I don’t see an exact application given the context, but I do agree it’s beneficial and can help lead any discussion here. From what I recall, that issue is around semantics of what constitutes what we would refer to as a “component”. We can also lean on the parts enumerated in Open UI though as we look to update those. Control in our case here is typically what we are referencing as a specific part.

@yinonov
Copy link
Contributor Author

yinonov commented Mar 20, 2022

I believe openui/open-ui#81 addresses this issue exactly

I think the intent here is slightly different, so I don’t see an exact application given the context, but I do agree it’s beneficial and can help lead any discussion here. From what I recall, that issue is around semantics of what constitutes what we would refer to as a “component”. We can also lean on the parts enumerated in Open UI though as we look to update those. Control in our case here is typically what we are referencing as a specific part.

if it has any resemblance, it, at least, excludes References the root element from meeting control criterions, right?

@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-components has been deprecated for some time and we are deprecating @microsoft/fast-foundation, so this issue is obsolete.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid
Projects
None yet
Development

No branches or pull requests

3 participants