Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This pull request introduces new constants and functions to support additional Git provider types, adds a new item type, and updates the permissions requirements for various domain-related operations. The most important changes are listed below: ### New Constants and Functions * Added `GitProviderType` constants for Azure DevOps and GitHub, along with a function `PossibleGitProviderTypeValues` to return these values. (`fabric/admin/constants.go`) ### New Item Type * Introduced a new item type `ItemTypeKQLDashboard` and updated the `PossibleItemTypeValues` function to include this new type. (`fabric/admin/constants.go`) [[1]](diffhunk://#diff-371ce6b689c990eea8d4e59006c92805ade980163c5b2aac7352370c3a88afd4R227-R228) [[2]](diffhunk://#diff-371ce6b689c990eea8d4e59006c92805ade980163c5b2aac7352370c3a88afd4R266) ### Permissions Updates * Updated permissions requirements for various domain-related operations to specify that the caller must be a Fabric administrator instead of having broader administrator rights. (`fabric/admin/domains_client.go`) [[1]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L35-R35) [[2]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L58-R58) [[3]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L93-R93) [[4]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L112-R112) [[5]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L150-R150) [[6]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L169-R169) [[7]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L192-R192) [[8]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L227-R227) [[9]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L244-R244) [[10]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L282-R281) [[11]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L304-R303) [[12]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L341-R339) [[13]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L355-R353) [[14]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L392-R390) [[15]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L416-R414) [[16]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L482-R480) [[17]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L542-R540) [[18]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L581-R578) [[19]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L598-R595) [[20]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L654-R650) [[21]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L692-R687) ### Code Refactoring * Refactored various functions to remove unused parameters in the `DomainsClient` struct methods. (`fabric/admin/domains_client.go`) [[1]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L93-R93) [[2]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L150-R150) [[3]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L227-R227) [[4]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L282-R281) [[5]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L341-R339) [[6]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L392-R390) [[7]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L482-R480) [[8]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L542-R540) [[9]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L598-R595) [[10]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L654-R650) [[11]](diffhunk://#diff-bf18d1229d7cd9d8a626133b30f86bad8e0972d9d73188a401b6a76b5433d164L692-R687)
- Loading branch information