Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug EBPF MSI - Doc update #3970

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

vpidatala94
Copy link
Collaborator

This is documentation update regarding runtime debug DLL of EBPF install instructions using Debug EBPF MSI.

Fixes #3872

@vpidatala94
Copy link
Collaborator Author

image

@lmb
Copy link
Collaborator

lmb commented Oct 31, 2024

This means that having visual studio installed is enough for this to work? Is it possible to add a check to the installer to this effect?

Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this this is going in the wrong direction of requiring more action from users rather than less, and hence makes the developer story worse in my opinion.

@vpidatala94
Copy link
Collaborator Author

This means that having visual studio installed is enough for this to work? Is it possible to add a check to the installer to this effect?

the debug DLL should be in a location included %PATH% and readable by the EBPF services. The base requirement as I see are the debug DLL, coupling visual studio as a flag in the installer is unnecessary from my point of view. In a debug scenario the recommended way to install EBPF is using setup-ebpf.ps1 script, if the customer chooses to use the debug EBPF MSI, the above steps are recommended

@shankarseal shankarseal modified the milestones: 2410, 2411 Nov 2, 2024
@vpidatala94
Copy link
Collaborator Author

Hi Dave, wanted your thoughts on this issue again, the request was to investigate if the DEBUG MSI can run a script to copy the binaries to a select location (JIT subfolder) such that it can be picked up by the EBPF svc. Wanted to share my concern here Installers in general do not have external dependencies. This is an atypical scenario where we are not allowed to redistribute debug MSVCRT and static linking is not possible as well. My proposition is take the route of educating the customers using documentation to use setup-ebpf.ps1 script as the preferred way to install ebpf in debug mode or perform the manual steps of copying debug MSVCRT to the JIT subfolder.

@dthaler
Copy link
Collaborator

dthaler commented Nov 14, 2024

Hi Dave, wanted your thoughts on this issue again, the request was to investigate if the DEBUG MSI can run a script to copy the binaries to a select location (JIT subfolder) such that it can be picked up by the EBPF svc. Wanted to share my concern here Installers in general do not have external dependencies. This is an atypical scenario where we are not allowed to redistribute debug MSVCRT and static linking is not possible as well. My proposition is take the route of educating the customers using documentation to use setup-ebpf.ps1 script as the preferred way to install ebpf in debug mode or perform the manual steps of copying debug MSVCRT to the JIT subfolder.

We should not make developers lives difficult simply due to what we are allowed to do, when there is a way to not make their lives difficult. Users don't need to know whether there are external dependencies or not.

@Alan-Jowett Alan-Jowett marked this pull request as draft November 22, 2024 22:05
@shankarseal shankarseal removed this from the 2411 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing Debug build MSI leads to ebpfsvc.exe not being able to start
4 participants