Return EBUSY if driver is still being unloaded #3794
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
|
UM tests are failing during native load |
Alan-Jowett
force-pushed
the
issue2133
branch
3 times, most recently
from
1a17371 to
30907b8
Compare
Alan-Jowett
force-pushed
the
issue2133
branch
from
c1daefa to
4c7d133
Compare
added 3 commits
October 4, 2024 13:45
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2133
Description
This pull request introduces a new error code
EBPF_BUSYto handle situations where operations cannot be completed due to the system being busy. The changes span multiple files to integrate this new error code into the existing error handling framework.Error Handling Enhancements:
include/ebpf_result.h: AddedEBPF_BUSYto theebpf_result_tenumeration to represent a busy system state.libs/api/ebpf_api.cpp: Updated_ebpf_program_load_nativeto mapEBPF_OBJECT_NOT_FOUNDtoEBPF_BUSYwhen the service is still being deleted.libs/api_common/api_common.hpp: Modifiedebpf_result_to_errnoto convertEBPF_BUSYto theEBUSYerror code.libs/runtime/ebpf_error.c: AddedEBPF_BUSYto the_ebpf_result_mappingarray to map it toSTATUS_DEVICE_BUSY.libs/runtime/kernel/ebpf_native_kernel.c: Adjustedebpf_native_load_driverto setEBPF_OBJECT_NOT_FOUNDwhen the status isSTATUS_OBJECT_NAME_NOT_FOUND.Testing Enhancements:
tests/api_test/api_test.cpp: Added a loop to retry loading a BPF object if the system is busy and introduced a new test case for the program load/attach/detach/unload cycle. [1] [2]Testing
CI/CD
Documentation
No.
Installation
No.