PS: Small dbscheme updates #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Flip the name of the child and parent column for 'parent' to reflect how this is actually populated by the extractor. 2. Make some of the coumns more specific to the actual data type. 3. Make `@named_attribute_argument` an `@ast` branch.
…nning the script in 'github/codeql/blob/main/misc/scripts/prepare-db-upgrade.sh' (after adding powershell to line 83).
… are basically noopts in this case.
LWSimpkins
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of small annoyances I've encountered in the Powershell dbscheme. They're all written in the first commit of this PR:
how this is actually populated by the extractor.
@named_attribute_argumentan@astbranch.The remaining commits go through creating a database upgrade script
Commit-by-commit review recommended