Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banking.ts authorization failure returns 404 instead of 403 #247

Open
beejones opened this issue Feb 7, 2024 · 1 comment
Open

Banking.ts authorization failure returns 404 instead of 403 #247

beejones opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@beejones
Copy link

beejones commented Feb 7, 2024

When authentication passes but validation fails, we need to return 403 and not 404.
This is an example of what is in the code on the endpoints
if (!validateUserId(userId)) {
return {
statusCode: 404,
};
}
The status code must be 403.

@beejones beejones added the bug Something isn't working label Feb 7, 2024
@ross-p-smith
Copy link
Contributor

Hi @beejones - if you create a PR - I'll happily review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants