Adds icon searching for issue #633

[drusteeby]

Fixes issue #685 ( tracked by the parent issue #633 )

Moved IconPageViewModel to the DesignGuidance page for consistency

Uses parallel filtering as opposed to CollectionView filtering for faster performance with large iconsets.

Microsoft Reviewers: Open in CodeFlow

[drusteeby]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

[dipeshmsft]

I took a quick look at the PR, there is one feature that is missing from the current setup,

In the recent updates on WinUI Gallery, the team has added tags for each icon to allow searching icons by tags. I would like to import that behavior in WPF Gallery as well. I am okay with raising a separate PR for this.

[drusteeby]

I took a quick look at the PR, there is one feature that is missing from the current setup,

In the recent updates on WinUI Gallery, the team has added tags for each icon to allow searching icons by tags. I would like to import that behavior in WPF Gallery as well. I am okay with raising a separate PR for this.

If there's an issue open for this or you make one go ahead and assign me

[dipeshmsft]

If there's an issue open for this or you make one go ahead and assign me

Once this PR is done I will create an issue for the above request.

[dipeshmsft]

@drusteeby, I was taking a look at the PR and here are a few points:

1. The width of that search text box should be fixed.
2. When you clear the textbox, the UI hangs for a few seconds, I think we should fix that.

[drusteeby]

@drusteeby, I was taking a look at the PR and here are a few points:

1. The width of that search text box should be fixed.
2. When you clear the textbox, the UI hangs for a few seconds, I think we should fix that.

@dipeshmsft
I can match the with of the textbox to the WinUIGallery.

The UI is hanging because WrapPanel does not support virtualization. What would be your suggested solution for that?

[dipeshmsft]

I can match the with of the textbox to the WinUIGallery.

Great, can you add a Label before the textbox, something like "Search" / "Search Icons".
I know we don't have a placeholder but without a placeholder / label it seems a little out of place.

The UI is hanging because WrapPanel does not support virtualization. What would be your suggested solution for that?

Regarding this let me take a look at it. If there is a quick solution then we will take it along with this PR, otherwise we will deal with it separately ? Does that sound okay to you ?

[dipeshmsft]

@drusteeby , I have created the issue #686 as mentioned above to allow icon search using tags.

[drusteeby]

I can match the with of the textbox to the WinUIGallery.

Great, can you add a Label before the textbox, something like "Search" / "Search Icons". I know we don't have a placeholder but without a placeholder / label it seems a little out of place.

The UI is hanging because WrapPanel does not support virtualization. What would be your suggested solution for that?

Regarding this let me take a look at it. If there is a quick solution then we will take it along with this PR, otherwise we will deal with it separately ? Does that sound okay to you ?

Yeah all sounds good.

At first I attempted to add a "loading spinner", which didn't work well because it was the UI thread itself taking the time. It also hangs when you first open the page. WinUIGallery loads the icons on app startup but I don't think that would gain much improvement here.

[dipeshmsft]

At first I attempted to add a "loading spinner", which didn't work well because it was the UI thread itself taking the time.

Yeah, I remember, I tried this earlier as well. Didn't work for the same reasoning.