Correct optionality of ReadableStreamReadDoneResult.value
#1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Renegade334
changed the title
ReadableStreamReadValueResult.valueReadableStreamReadDoneResult.value
|
Technically it's optional per the IDL , but the behavior always assigns value there. So LGTM. |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streams protocol specifies for
ReadableStreamReadResultthat thevalueproperty is always present. If the stream is cancelled, then this property won't be absent, but will be present with the valueundefined. (This differs from eg. the iterator protocol, where a result object'svalueproperty may indeed be absent if the iterator is closed.)The difference is only really manifest when
exactOptionalPropertyTypesis enabled, but where it is,ReadableStreamReadDoneResultis currently divergent from the web standard.