-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core dependencies #1891
Update core dependencies #1891
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
baselines/dom.generated.d.ts
Outdated
@@ -18266,8 +18266,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |||
readonly responseStart: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full Safari and firefox support is there.
https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStart#browser_compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MDN hasn't been updated yet, but I don't think the BCD PR is right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we're deleting this? responseStart
has been supported for a long time. It's just what "responseStart" mean changed slightly in Chrome 115, and has been changed back since Chrome 133. See: https://chromestatus.com/feature/5158830722514944. That's why we updated BCD to make a noted of that.
But in terms of typescript, reponseStart
was always present and was always a DOMHighResTimeStamp
. So that note shouldn't change anything in typescript.
d0f76ee
to
cc1ade5
Compare
cc1ade5
to
abd5ea3
Compare
@@ -4336,8 +4345,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back incorrectly removed responseStart
readonly responseEnd: DOMHighResTimeStamp; | |
readonly responseEnd: DOMHighResTimeStamp; | |
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |
readonly responseStart: DOMHighResTimeStamp; |
@@ -4208,8 +4217,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back incorrectly removed responseStart
readonly responseEnd: DOMHighResTimeStamp; | |
readonly responseEnd: DOMHighResTimeStamp; | |
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |
readonly responseStart: DOMHighResTimeStamp; |
@@ -4336,8 +4345,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back incorrectly removed responseStart
readonly responseEnd: DOMHighResTimeStamp; | |
readonly responseEnd: DOMHighResTimeStamp; | |
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |
readonly responseStart: DOMHighResTimeStamp; |
@@ -4208,8 +4217,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back incorrectly removed responseStart
readonly responseEnd: DOMHighResTimeStamp; | |
readonly responseEnd: DOMHighResTimeStamp; | |
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |
readonly responseStart: DOMHighResTimeStamp; |
@@ -4910,8 +4921,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back incorrectly removed responseStart
readonly responseEnd: DOMHighResTimeStamp; | |
readonly responseEnd: DOMHighResTimeStamp; | |
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |
readonly responseStart: DOMHighResTimeStamp; |
baselines/webworker.generated.d.ts
Outdated
@@ -4910,8 +4921,6 @@ interface PerformanceResourceTiming extends PerformanceEntry { | |||
readonly requestStart: DOMHighResTimeStamp; | |||
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseEnd) */ | |||
readonly responseEnd: DOMHighResTimeStamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add back incorrectly removed responseStart
:
readonly responseEnd: DOMHighResTimeStamp; | |
readonly responseEnd: DOMHighResTimeStamp; | |
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/responseStart) */ | |
readonly responseStart: DOMHighResTimeStamp; |
This is because now surprisingly there are two sources of truth in BCD for responseStart. I strongly believe BCD should remove that, but until then we have a way to override BCD data. |
Can you explain what you mean by that? I did the BCD updates so can see if there's a better way to do this (I'm not totally happy how it shows on MDN either). But, as per, #1891 (comment) the point was to note that Chrome diverged from the definition for a short period and this might surprise some developers—hence why we wanted it documented in MDN/BCD. |
Reverting the problematic updates in BCD here: #25876 |
Here the two sources means the support data with
We can somehow deal with it by merging support data (we have that for mixins), but I don't think that's worth given |
abd5ea3
to
c1de65c
Compare
Looks like the |
Automated changes by create-pull-request GitHub action