Refactor readers to reduce surface area #1975
Open
+613
−577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng and
andrueastman
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…quired Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…nAPI.NET into mk/fix-json-reader
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…nAPI.NET into mk/fix-json-reader
There was a problem hiding this comment.
Copilot reviewed 15 out of 30 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiCallbackTests.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs: Evaluated as low risk
- src/Microsoft.OpenApi/Interfaces/IOpenApiReader.cs: Evaluated as low risk
- src/Microsoft.OpenApi/Models/OpenApiDocument.cs: Evaluated as low risk
- src/Microsoft.OpenApi/Reader/OpenApiJsonReader.cs: Evaluated as low risk
- src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiEncodingTests.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDiscriminatorTests.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiExampleTests.cs: Evaluated as low risk
- src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs: Evaluated as low risk
- src/Microsoft.OpenApi.Hidi/OpenApiService.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiSchemaTests.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiDocumentTests.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Hidi.Tests/Services/OpenApiFilterServiceTests.cs: Evaluated as low risk
- test/Microsoft.OpenApi.Readers.Tests/OpenApiReaderTests/OpenApiDiagnosticTests.cs: Evaluated as low risk
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
| { | ||
| throw new InvalidOperationException($"Could not download the file at {url}", ex); | ||
| // YAML or other non-JSON format; copy remaining input to a new stream. | ||
| preparedStream = new MemoryStream(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| { | ||
| throw new InvalidOperationException($"Could not open the file at {url}", ex); | ||
| // Buffer stream for non-JSON formats (e.g., YAML) since they require synchronous reading | ||
| preparedStream = new MemoryStream(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
Closed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1954
fixes #1951
Fixes #1964
Fixes #1917
closes #1958
closes #1929