Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rename Microsoft.OpenApi.Readers to Microsoft.OpenApi.YamlReader #1960

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix: Rename Microsoft.OpenApi.Readers to Microsoft.OpenApi.YamlReader #1960

wants to merge 3 commits into from

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1957

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

darrelmiller
darrelmiller approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to update the publishing pipeline to ship this new nuget package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API review] Rename Microsoft.OpenAPI.readers to Microsoft.OpenAPI.YAML.reader
2 participants
@MaggieKimani1 @darrelmiller