Refactor readers to reduce surface area #1958
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| JsonNode jsonNode; | ||
|
|
||
| // Parse the YAML text in the TextReader into a sequence of JsonNodes | ||
| try | ||
| { | ||
| jsonNode = LoadJsonNodesFromYamlDocument(input); | ||
| jsonNode = LoadJsonNodesFromYamlDocument(new StreamReader(input)); // Should we leave the stream open? |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| @@ -56,7 +73,7 @@ | |||
| // Parse the YAML | |||
| try | |||
| { | |||
| jsonNode = LoadJsonNodesFromYamlDocument(input); | |||
| jsonNode = LoadJsonNodesFromYamlDocument(new StreamReader(input)); | |||
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| return ParseAsync(input, reader, format, settings).GetAwaiter().GetResult(); | ||
| #pragma warning restore VSTHRD002 // Avoid problematic synchronous waits | ||
| // Copy string into MemoryStream | ||
| var stream = new MemoryStream(Encoding.UTF8.GetBytes(input)); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| @@ -195,8 +163,8 @@ | |||
| { | |||
| format ??= OpenApiConstants.Json; | |||
| settings ??= new OpenApiReaderSettings(); | |||
| using var reader = new StringReader(input); | |||
| return Load<T>(reader, version, out diagnostic, format, settings); | |||
| var stream = new MemoryStream(Encoding.UTF8.GetBytes(input)); | |||
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| { | ||
| return Load<T>(memoryStream, version, format, out diagnostic, settings); | ||
| } else { | ||
| memoryStream = new MemoryStream(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| var reader = OpenApiReaderRegistry.GetReader(format); | ||
| var readResult = await reader.ReadAsync(input, settings, cancellationToken); | ||
|
|
||
| if (settings.LoadExternalRefs) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
| private static ReadResult InternalLoad(MemoryStream input, string format, OpenApiReaderSettings settings = null) | ||
| { | ||
| Utils.CheckArgumentNull(format, nameof(format)); | ||
| if (settings.LoadExternalRefs) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
|
No description provided.