Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - We should NOT do sync over async #1917

Closed
baywet opened this issue Nov 12, 2024 · 3 comments · Fixed by #1975
Closed

v2 - We should NOT do sync over async #1917

baywet opened this issue Nov 12, 2024 · 3 comments · Fixed by #1975
Milestone

Comments

@baywet
Copy link
Member

baywet commented Nov 12, 2024

6 instances being suppressed

https://github.com/search?q=repo%3Amicrosoft%2FOpenAPI.NET%20VSTHRD002%20&type=code

This will cause poor performance and potential dead locks on backend services.

One of those instances is marked as obsolete, we should simply clean it up (and make a pass to ensure we remove any other obsolete API)

The five others were introduced with this preview. We should remove those methods, and let the consumer do the blocking if they absolutely need to with the proper patterns in terms of thread and context management

@darrelmiller
Copy link
Member

Resolved with refactoring of factory methods

@baywet baywet reopened this Dec 19, 2024
@baywet
Copy link
Member Author

baywet commented Dec 19, 2024

That PR has not been merged yet @darrelmiller

@baywet
Copy link
Member Author

baywet commented Dec 19, 2024

See #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants