Skip to content
Sonarcloud

Refactor readers to reduce surface area #1299

Sign in to view logs

Refactor readers to reduce surface area

Refactor readers to reduce surface area #1299

Triggered via pull request December 20, 2024 09:31
@MaggieKimani1MaggieKimani1
synchronize #1975
mk/fix-json-reader
Status Success
Total duration 7m 43s
Artifacts –

sonarcloud.yml

on: pull_request
check if SONAR_TOKEN is set in github secrets
0s
check if SONAR_TOKEN is set in github secrets
Build
7m 13s
Build
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
check if SONAR_TOKEN is set in github secrets
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build: src/Microsoft.OpenApi/Models/OpenApiSecurityRequirement.cs#L126
Private classes which are not derived in the current assembly should be marked as 'sealed'. (https://rules.sonarsource.com/csharp/RSPEC-3260)
Build: src/Microsoft.OpenApi/Extensions/OpenAPIWriterExtensions.cs#L5
Rename class 'OpenAPIWriterExtensions' to match pascal case naming rules, consider using 'OpenApiWriterExtensions'. (https://rules.sonarsource.com/csharp/RSPEC-101)
Build: src/Microsoft.OpenApi/Reader/V2/OpenApiSecuritySchemeDeserializer.cs#L74
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
Build: src/Microsoft.OpenApi/Writers/OpenApiYamlWriter.cs#L75
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
Build: src/Microsoft.OpenApi/Reader/OpenApiDiagnostic.cs#L56
Move 'IDiagnosticExtensions' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
Build: src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs#L41
Define a constant instead of using this literal 'boolean' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
Build: src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs#L42
Define a constant instead of using this literal 'integer' 8 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
Build: src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs#L43
Define a constant instead of using this literal 'number' 14 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
Build: src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs#L44
Define a constant instead of using this literal 'string' 13 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
Build: src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs#L64
Define a constant instead of using this literal 'double' 7 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)