Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pypi packaging #626

Merged
merged 42 commits into from
Jan 9, 2024
Merged

Pypi packaging #626

merged 42 commits into from
Jan 9, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Jan 9, 2024

No description provided.

bpkroth added 30 commits January 8, 2024 18:07
@bpkroth
improve some metadata for packaging purposes
ae59566
@bpkroth
add some comments about the keyvault secrets configs
ad210d9
@bpkroth
remove reference to an old file
de9821a
@bpkroth
comments
2d8aeab
@bpkroth
Bump version: 0.1.0 → 0.2.0
0cb681f
@bpkroth
improvements on readme
1b5fcc6
@bpkroth
Bump version: 0.2.0 → 0.2.1
29eaefb
@bpkroth
initial attempts at publishing pypi packages
944472b
@bpkroth
fixups for when matplotlib is not installed
797d6d3
@bpkroth
Bump version: 0.2.1 → 0.2.2
3b40ded
@bpkroth
fixups
abf48ad
@bpkroth
Revert "Bump version: 0.2.1 → 0.2.2"
919fd95 
This reverts commit 3b40ded.
@bpkroth
tweak
74037fc
@bpkroth
Bump version: 0.2.1 → 0.2.2
ec793a4
@bpkroth
fixups
eaa8e64
@bpkroth
Add rules for publishing packages
07c60fb
@bpkroth
need the extra file for the container build
90f550f
@bpkroth
pylint fixups
3284c42
@bpkroth
don't require the readme to rebuild the devcontainer - breaks the cache
4b39ff8
@bpkroth
remove explicit version numbers from the readme
de431e9
@bpkroth
update readme
dee63d1
@bpkroth
fixups
46523e7
@bpkroth
tweaks
857f635
@bpkroth
link fixup
241f749
@bpkroth
fixups
8993a67
@bpkroth
also tag devcontainers
d45293f
@bpkroth
cosmetic
59b471f
@bpkroth
FIXME: increase rebuild timeout
9124792
@bpkroth
testing
7c58d23
@bpkroth
to avoid file overwrites only execute on tag pushes, not release
e42b1ce
@bpkroth bpkroth requested a review from a team as a code owner January 9, 2024 20:41
@bpkroth bpkroth marked this pull request as draft January 9, 2024 20:50
@bpkroth bpkroth marked this pull request as ready for review January 9, 2024 21:54
@bpkroth bpkroth added the ready for review Ready for review label Jan 9, 2024
@bpkroth bpkroth linked an issue Jan 9, 2024 that may be closed by this pull request
publish mlos packages on pypi #547
Closed
motus
motus approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left a few comments - all minor, except for one potential typo in regex

@bpkroth @motus
Update Makefile
e7defbd 
Co-authored-by: Sergiy Matusevych <sergiy.matusevych@gmail.com>
@bpkroth bpkroth enabled auto-merge (squash) January 9, 2024 22:31
@bpkroth bpkroth merged commit c7df7ff into microsoft:main Jan 9, 2024
11 checks passed
@bpkroth bpkroth deleted the pypi-packaging branch January 9, 2024 22:40
This was referenced Jan 16, 2024
Closed
Merged
bpkroth added a commit that referenced this pull request Jan 16, 2024
@bpkroth
CI tweak: use "release" event instead of "tag push" for pypi publishi…
42a149f 
…ng (#631)

Minor tweak on #626: instead of acting on tag push events, we only act
on "release" events. This gives us a chance to fix bad tag pushes (which
otherwise don't have much gated checking on them) prior to attempting to
publish a version on pypi, which cannot be overwritten (only
superseded).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

publish mlos packages on pypi
2 participants
@bpkroth @motus