Run copy results after tests failures #23964
Open
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
PR Overview
This PR is focused on debugging why copy results are not running after test failures. Key changes include:
- Modifying a test assertion in DynamicComposedChart.test.tsx.
- Updating the pipeline condition in build-npm-client-package.yml to only check if startTest is true.
Reviewed Changes
| File | Description |
|---|---|
| packages/tools/devtools/devtools-view/src/test/DynamicComposedChart.test.tsx | Changes the test assertion which now contradicts itself by expecting the element to be both null and defined. |
| tools/pipelines/templates/build-npm-client-package.yml | Removes the succeededOrFailed() condition, which may prevent copying results when tests fail. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
dannimad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating pipeline conditions to run copy results even after tests failures.