-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove getContainerPackageInfo public api from container.ts #23941
Draft
MarioJGMsoft
wants to merge
14
commits into
microsoft:main
Choose a base branch
from
MarioJGMsoft:removeGetContainerPackageName
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove getContainerPackageInfo public api from container.ts #23941
MarioJGMsoft
wants to merge
14
commits into
microsoft:main
from
MarioJGMsoft:removeGetContainerPackageName
+14
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: loader
Loader related issues
base: main
PRs targeted against main branch
changeset-present
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With PR: #22849 we introduced a non-generic api into container-loader layer which we should remove.
Since it is public, we will first mark it as deprecated, and then in the next release remove it. Make sure we inform Loop to not take dependency on it.
This is the follow up task to make sure that the api gets eliminated properly.
Reviewer Guidance
Please let me know if there is anything I should keep in mind while doing this work
Fixes: AB#31203