-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update dependencies on @microsoft/api-extractor
to version 7.50.1
#23932
base: main
Are you sure you want to change the base?
build: Update dependencies on @microsoft/api-extractor
to version 7.50.1
#23932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request updates dependency versions in the pnpm lockfile to ensure compatibility with the new @microsoft/api-extractor@7.50.1 release. Key changes include updating @microsoft/api-extractor (and its model), bumping TypeScript from 5.4.5 to 5.7.3, and synchronizing related package versions (e.g. fs-extra, @types/node, and others) across the lockfile.
Reviewed Changes
File | Description |
---|---|
common/lib/protocol-definitions/pnpm-lock.yaml | Updated dependency versions to support @microsoft/api-extractor@7.50.1 |
Copilot reviewed 107 out of 107 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
common/lib/protocol-definitions/pnpm-lock.yaml:4507
- The TypeScript version has been updated to 5.7.3. Please verify that all consuming tooling and dependent packages are compatible with this upgrade to avoid potential breaking changes.
typescript@5.7.3: resolution: {integrity: sha512-84MVSjMEHP+FQRPy3pX9sTVV/INIex71s9TL2Gm5FG/WG1SqXeKyZ0k7/blY/4FdOzI12CBy1vGc4og/eus0fw==}
common/lib/protocol-definitions/pnpm-lock.yaml:11
- The patched dependency for @microsoft/api-extractor is updated to 7.50.1; please confirm that the accompanying patch file and its associated hash are correct and intentional.
'@microsoft/api-extractor@7.50.1':
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not making progress on getting our patches into api-extractor?
@@ -39090,6 +39025,18 @@ snapshots: | |||
- supports-color | |||
- typescript | |||
|
|||
jest-environment-puppeteer@10.1.4(typescript@5.7.3): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone's dev dependencies are bleeding through? I would not have expected a test update like this.
version: 10.1.4(typescript@5.4.5) | ||
version: 10.1.4(typescript@5.7.3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one place I see the qualification change. I guess jest will use the latest version of typescript it finds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jest-environment-puppeteer
doesn't specify any direct dependencies of any kind on typescript
, seems like it comes through its dependency on cosmiconfig
, which does declare a devDep on "typescript": "^5.2.2"
and got a new entry with typescript 5.7.3.
Unfortunately, no not really. We haven't really gotten any implementation support from them. I've been able to get advice on how to fix some issues myself, but that's been mostly the extent. I've fixed some issues myself, but I haven't had the necessary time scheduled to do much. |
I looked into the errors api-extractor produces with this update and it seems like an api-extractor issue. Here is a sample of reference errors that look suspect:
It says |
I took a guess that merging with #21725, which simplifies presence package structure, might help clear up some errors. |
Also updates
typescript
and@types/node
inapi-markdown-documenter
to be compatible with theapi-extractor
update.This PR does not update dependencies under
server/routerlicious
due to the same version incompatibilities. Those packages will need to be addressed separately.