build: limit .d.ts clean to known generated #23373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that custom checked-in files remain intact
There was a problem hiding this comment.
Copilot reviewed 42 out of 62 changed files in this pull request and generated no comments.
Files not reviewed (20)
- azure/packages/azure-service-utils/package.json: Language not supported
- common/lib/protocol-definitions/package.json: Language not supported
- experimental/framework/tree-react-api/package.json: Language not supported
- packages/common/container-definitions/package.json: Language not supported
- packages/common/core-interfaces/package.json: Language not supported
- packages/common/core-utils/package.json: Language not supported
- packages/common/driver-definitions/package.json: Language not supported
- packages/dds/cell/package.json: Language not supported
- packages/dds/counter/package.json: Language not supported
- packages/dds/map/package.json: Language not supported
- packages/dds/matrix/package.json: Language not supported
- packages/dds/merge-tree/package.json: Language not supported
- packages/dds/ordered-collection/package.json: Language not supported
- packages/dds/register-collection/package.json: Language not supported
- packages/dds/sequence/package.json: Language not supported
- packages/dds/shared-object-base/package.json: Language not supported
- packages/dds/shared-summary-block/package.json: Language not supported
- packages/dds/task-manager/package.json: Language not supported
- packages/dds/tree/package.json: Language not supported
- packages/drivers/debugger/package.json: Language not supported
github-actions
bot
added
area: dds
|
could you add a bit more description to the pr, such that if anyone wants to understand more deeply why we only cleans those up by looking at the blame history they could. |
github-actions
bot
added
area: dds
github-actions
bot
added
area: driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that custom checked-in files remain intact.
cleanis now limited to those that are also listed in.gitignore. Other root .d.ts files may need to exist in support of Node10 module resolution tsc configuration.