Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-presence): disabled (failing) attendees unit tests #23345

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Dec 17, 2024

Description

A few unit tests were added disabled as current implementation does not meet expectations. This PR enable these tests and updates implementation:

Presence
  PresenceManager
    when connected
      attendee
        that is joining
          - second time is announced once via `attendeeJoined` with status "Connected" when prior is still connected
          - first time is announced via `attendeeJoined` with status "Connected" even if unknown to audience
        that is already known
          - is not announced via `attendeeJoined` when already "Connected"`

Changes include:

  • Additional test case that tests collateral client with old connection ID
  • Defining a joining attendee as a connected attendee that has a connectionId that has not been seen before by the recipient.
  • When the local attendee disconnects, we temporarily lose connectivity status for remote attendees. To fix this we mark all remote attendee connections as stale upon reconnect and update their status to disconnected after 30 seconds of inactivity.

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch labels Dec 17, 2024
@WillieHabi WillieHabi marked this pull request as ready for review December 17, 2024 20:23
@Copilot Copilot bot review requested due to automatic review settings December 17, 2024 20:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@WillieHabi WillieHabi marked this pull request as draft December 17, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant