Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated summarizeProtocolTree option #23319

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pragya91
Copy link
Contributor

@pragya91 pragya91 commented Dec 12, 2024

Removed deprecated ILoaderOption = summarizeProtocolTree.

summarizeProtocolTree property in ILoaderOptions (the extended definition in container layer) was added to test single-commit summaries during the initial implementation phase. The flag is no longer required or should be used, so marked it as deprecated. If a driver needs to enable or disable single-commit summaries, it can do so via IDocumentServicePolicies.

AB#9098
#23320

@github-actions github-actions bot added area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Dec 12, 2024
@pragya91 pragya91 requested review from a team, markfields, jatgarg, tyler-cai-microsoft, kian-thompson, rajatch-ff and MarioJGMsoft and removed request for a team December 12, 2024 23:19
@markfields
Copy link
Member

How much of this can you check in now, without including the actual break? e.g. the changes in packages/test/test-service-load/src/optionsMatrix.ts look like they can happen first? To leave this break PR as minimal as possible.

@pragya91 pragya91 force-pushed the praggarg/remove-deprecated-summaryprotocol branch from 9524d20 to 748c144 Compare December 16, 2024 21:28
@pragya91 pragya91 force-pushed the praggarg/remove-deprecated-summaryprotocol branch from 748c144 to 476606c Compare December 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants