Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm9 #23318

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Pnpm9 #23318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6091a1d
Update client to pnpm 9
CraigMacomber Jun 4, 2024
737ac14
Make version 9.9.9 so bug repro will be stable across publishing RC5
CraigMacomber Jun 4, 2024
f9a97ca
chore: enable link-workspace-packages
KSXGitHub Jun 5, 2024
1d9f7cc
Merge pull request #4 from KSXGitHub/patch-1
CraigMacomber Jun 6, 2024
f48a188
Revert "Make version 9.9.9 so bug repro will be stable across publish…
CraigMacomber Jun 6, 2024
241cd57
Update lock file
CraigMacomber Jun 6, 2024
08b812d
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber Jun 6, 2024
1081000
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber Oct 2, 2024
ad97ade
Update lock file
CraigMacomber Oct 2, 2024
097cad6
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber Oct 11, 2024
14edb2b
Update lock file
CraigMacomber Oct 11, 2024
512234c
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber Dec 12, 2024
40ac441
Update lock file
CraigMacomber Dec 12, 2024
7288160
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber Dec 12, 2024
ee53880
Fix lock
CraigMacomber Dec 12, 2024
229ee55
Merge branch 'main' of https://github.com/microsoft/FluidFramework in…
CraigMacomber Dec 13, 2024
563895a
update independent packages
CraigMacomber Dec 13, 2024
21b29f2
pnpm exec flub exec "--releaseGroupRoot=all" -- "pnpm i --no-frozen-l…
CraigMacomber Dec 13, 2024
58ca511
Merge branch 'main' into test/crmacomb/pnpm9
CraigMacomber Dec 13, 2024
b869b51
Update npmrcs
CraigMacomber Dec 13, 2024
06c1d60
Merge https://github.com/microsoft/FluidFramework into Pnpm9
CraigMacomber Dec 13, 2024
bc71916
Update npmrcs
CraigMacomber Dec 13, 2024
7b34a20
Merge branch 'Pnpm9' of https://github.com/CraigMacomber/FluidFramewo…
CraigMacomber Dec 13, 2024
492479b
Merge branch 'test/crmacomb/pnpm9' of https://github.com/microsoft/Fl…
CraigMacomber Dec 13, 2024
0f3415a
Copy npmrc in Dockerfiles
CraigMacomber Dec 13, 2024
7bd8380
Add --no-frozen-lockfile to dockerfile
CraigMacomber Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
engine-strict=true
frozen-lockfile=true
strict-peer-dependencies=true
link-workspace-packages=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to pnpm defaults require this for workspace deps to function during install now.


# Disable pnpm update notifications since we use corepack to install package managers
update-notifier=false
# Don't use new lockfile format because component governance does not yet support it
use-lockfile-v6=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this did anything even before this change as I don't think pnpm 8 looked for this option. Regardless we are moving to format 9 now, so its out of date.

# Use the number of cores on the machine by default.
workspace-concurrency=0

Expand Down
3 changes: 1 addition & 2 deletions build-tools/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
engine-strict=true
frozen-lockfile=true
strict-peer-dependencies=true
link-workspace-packages=true

# Disable pnpm update notifications since we use corepack to install package managers
update-notifier=false
# Don't use new lockfile format because component governance does not yet support it
use-lockfile-v6=false
# Use the number of cores on the machine by default.
workspace-concurrency=0
2 changes: 1 addition & 1 deletion build-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"syncpack": "^9.8.6",
"typescript": "~5.4.5"
},
"packageManager": "pnpm@8.15.8+sha512.d1a029e1a447ad90bc96cd58b0fad486d2993d531856396f7babf2d83eb1823bb83c5a3d0fc18f675b2d10321d49eb161fece36fe8134aa5823ecd215feed392",
"packageManager": "pnpm@9.1.4+sha512.9df9cf27c91715646c7d675d1c9c8e41f6fce88246f1318c1aa6a1ed1aeb3c4f032fcdf4ba63cc69c4fe6d634279176b5358727d8f2cc1e65b65f43ce2f8bfb0",
"engines": {
"node": ">=18.17.1"
},
Expand Down
13,646 changes: 8,023 additions & 5,623 deletions build-tools/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions common/build/build-common/.npmrc
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have link-workspace-packages=true for consistency across our spaces? Or will we be trying to get rid of that in the other places?

Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ strict-peer-dependencies=true

# Disable pnpm update notifications since we use corepack to install package managers
update-notifier=false
# Don't use new lockfile format because component governance does not yet support it
use-lockfile-v6=false
2 changes: 1 addition & 1 deletion common/build/build-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@
"devDependencies": {
"prettier": "~3.0.3"
},
"packageManager": "pnpm@8.15.8+sha512.d1a029e1a447ad90bc96cd58b0fad486d2993d531856396f7babf2d83eb1823bb83c5a3d0fc18f675b2d10321d49eb161fece36fe8134aa5823ecd215feed392"
"packageManager": "pnpm@9.1.4+sha512.9df9cf27c91715646c7d675d1c9c8e41f6fce88246f1318c1aa6a1ed1aeb3c4f032fcdf4ba63cc69c4fe6d634279176b5358727d8f2cc1e65b65f43ce2f8bfb0"
}
9 changes: 6 additions & 3 deletions common/build/build-common/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions common/build/eslint-config-fluid/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ strict-peer-dependencies=true

# Disable pnpm update notifications since we use corepack to install package managers
update-notifier=false
# Don't use new lockfile format because component governance does not yet support it
use-lockfile-v6=false
2 changes: 1 addition & 1 deletion common/build/eslint-config-fluid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@
"sort-json": "^2.0.1",
"typescript": "~5.1.6"
},
"packageManager": "pnpm@8.15.8+sha512.d1a029e1a447ad90bc96cd58b0fad486d2993d531856396f7babf2d83eb1823bb83c5a3d0fc18f675b2d10321d49eb161fece36fe8134aa5823ecd215feed392"
"packageManager": "pnpm@9.1.4+sha512.9df9cf27c91715646c7d675d1c9c8e41f6fce88246f1318c1aa6a1ed1aeb3c4f032fcdf4ba63cc69c4fe6d634279176b5358727d8f2cc1e65b65f43ce2f8bfb0"
}
Loading
Loading