Skip to content

Commit

Permalink
Make ts-common-config.json extends tsconfig.base.json (#23532)
Browse files Browse the repository at this point in the history
## Description

Make deprecated common/build/build-common/ts-common-config.json extend
common/build/build-common/tsconfig.base.json.

This avoids duplicating things like selecting the target.

As noted in common/build/build-common/README.md, `tsconfig.base.json` is
the "base config contains defaults that all packages within the repo
should use as a baseline".
This change causes the packages which use `ts-common-config.json` to
follow this pattern, allowing `tsconfig.base.json` to better fill its
role as the actual base configuration which provides a single source of
truth for some of our build options.
  • Loading branch information
CraigMacomber authored Jan 13, 2025
1 parent cf15304 commit fd30517
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions common/build/build-common/ts-common-config.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,13 @@
{
// This configuration is deprecated and usages should be migrated to other options.
// The "common" in this file name means either that this is commonjs, or that this is a shared config since both are true.
"extends": ["./tsconfig.base.json"],
"exclude": ["dist", "node_modules"],
"compilerOptions": {
"target": "ES2020",
"declaration": true,
"declarationMap": true,
"esModuleInterop": true,
"composite": false,
"module": "commonjs",
"moduleResolution": "node",
"noUnusedLocals": true,
"sourceMap": true,
"inlineSources": true,
"noImplicitAny": false,
"incremental": true,
"types": [],
"strict": true,
"pretty": true,
"lib": ["ES2020", "DOM", "DOM.Iterable"]
"exactOptionalPropertyTypes": false,
"noUncheckedIndexedAccess": false
}
}

0 comments on commit fd30517

Please sign in to comment.